plugins/obs-ffmpeg: remove restart guard for RIST#13521
Open
RossWang wants to merge 1 commit into
Open
Conversation
We may not need this with the latest library version
pkviet
reviewed
Jun 8, 2026
Member
|
PS: for reference check the original PR adding the guard |
Author
|
The last commit (5e73e582f43e3dbfd3fee7cde44b8001740043e4) is good. Tested on OBS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove restart guard. Media Source running RIST can shutdown successfully when it becomes inactive.
Motivation and Context
Media Source with RIST protocol consuming 1 CPU core at 100% when not active. Updated to the latest library version solved the CPU issue but it is still running in the background which is not ideal. I think the original intention is to prevent crash. After years of development,
libristis much stable now. The guard can be removed.How Has This Been Tested?
(
libristinobs-depsneed to be updated accordingly)Types of changes
Checklist: